feat: allow nullable content-type#966
Merged
bartekpacia merged 7 commits intofluttercommunity:masterfrom Jul 25, 2024
Merged
Conversation
Contributor
Author
|
@salmaahhmed testing url can be for example https://download.mapsforge.org/maps/v5/europe/czech-republic.map |
Contributor
Author
|
@bartekpacia would you have a time to review this? :) |
bartekpacia
previously approved these changes
Jul 24, 2024
Collaborator
bartekpacia
left a comment
bartekpacia
left a comment
There was a problem hiding this comment.
hey, thanks for contributing!
Contributor
Author
|
Thank you for approval @bartekpacia! There was one kotlin lint issue, i fixed that, it needs just approval again 😄 |
Collaborator
|
Hey, thanks! I'm at work now but I'll make a release later today. |
Collaborator
|
released in v1.11.8 |
Contributor
Author
|
@bartekpacia thank you! |
wxuonline
pushed a commit
to wxuonline/flutter_downloader
that referenced
this pull request
Nov 13, 2024
* feat: allow empty content-type on android * feat: add nullable places for content type * feat: add nullable mimeType do worker * fix: add unknown type * fix: add unknown type * chore: fix lint issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android when source had null content-type, the request fails and throws exception. It's unexpected behavior since there is nothing wrong with downloaded file.
Proposing to resolve #935 and resolve #936